Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tuner] reduce log file size #809

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[tuner] reduce log file size #809

merged 1 commit into from
Jan 10, 2025
+2 −7

Conversation

bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Jan 10, 2025 •
edited
Loading

This PR aims to the log size detailed in: #806

  • Avoid printing the stdout and stderr of running the command
  • Reduce the precision of fp constants printed

@bangtianliu bangtianliu requested review from kuhar and Max191 January 10, 2025 00:31
kuhar
kuhar approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this needs to be rebased

@bangtianliu
Copy link
Contributor Author

LGTM but this needs to be rebased

Sure, will do.

@bangtianliu
[tuner] reduce log size
3d17d05 
Signed-off-by: Bangtian Liu <[email protected]>
@kuhar
Copy link
Member

kuhar commented Jan 10, 2025

@bangtianliu The PR description is out of date now, this point is no longer there:

Do not print candidate trackers at the end

@bangtianliu
Copy link
Contributor Author

@bangtianliu The PR description is out of date now, this point is no longer there:

Do not print candidate trackers at the end

Yeah, good catch!

@bangtianliu bangtianliu merged commit 371ef6e into nod-ai:main Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

@Max191 Max191 Awaiting requested review from Max191

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangtianliu @kuhar